SelectPanel: make item.id required #6898
Conversation
🦋 Changeset detectedLatest commit: 21fae66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
requested a deployment
to
storybook-preview-6898
There was a problem hiding this comment.
Pull Request Overview
This PR makes the id property required for SelectPanel items, addressing issue #5556. This is a breaking change that ensures better component reliability and accessibility by requiring unique identifiers for all items.
Key changes:
- Updated
FilteredActionListItemPropsinterface to makeidfield required instead of optional - Modified type definitions to enforce required
idfor custom item renderers - Updated all test files to include
idproperties for SelectPanel items
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/FilteredActionList/types.ts |
Made id field required in interfaces and updated type definitions |
packages/react/src/FilteredActionList/FilteredActionList.tsx |
Removed optional chaining for item.id since it's now guaranteed to exist |
packages/react/src/SelectPanel/SelectPanel.test.tsx |
Added required id properties to test item objects |
packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx |
Removed optional chaining when accessing item.id |
.changeset/selectpanel-item-id-required.md |
Added changeset documenting the breaking change |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3917 |
|
🔴 ci completed with status boo, this is because main is also failing integration |
github-actions
bot
added
integration-tests: failing
Rollout strategy
Testing & Reviewing
Merge checklist